Create a cron job that calls all performance harness on cron #31480

xiaohansong · 2023-10-16T22:35:12Z

What

Created a new workflow that calls connectors-performance-harness with different parameters so we can test all performance on schedule

Jobs will run in parallel and takes about 20 minutes to finish: https://github.com/airbytehq/airbyte/actions/runs/6539691823

How

input parameter now is inputs. rather thatn `github.events.inputs.
Add a cron schedule (5:30/17:30 everyday)
some minor setup for workflow_call setup and reuse existing commands

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Community member? Grant edit access to maintainers (instructions)
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Connector version is set to 0.0.1
- Dockerfile has version 0.0.1
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
- docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:generateScaffolds then checking in your changes
Documentation which references the generator is updated as needed

Updating the Python CDK

Airbyter

Before merging:

Pull Request description explains what problem it is solving
Code change is unit tested
Build and my-py check pass
Smoke test the change on at least one affected connector
- On Github: Run this workflow, passing --use-local-cdk --name=source-<connector> as options
- Locally: airbyte-ci connectors --use-local-cdk --name=source-<connector> test
PR is reviewed and approved

After merging:

Publish the CDK
- The CDK does not follow proper semantic versioning. Choose minor if this the change has significant user impact or is a breaking change. Choose patch otherwise.
- Write a thoughtful changelog message so we know what was updated.
Merge the platform PR that was auto-created for updating the Connector Builder's CDK version
- This step is optional if the change does not affect the connector builder or declarative connectors.

vercel · 2023-10-16T22:35:18Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Oct 20, 2023 5:52pm

rodireich · 2023-10-17T16:42:03Z

.github/workflows/connector-performance-cron.yml

+on:
+  schedule:
+    # * is a special character in YAML so you have to quote this string
+    - cron: "30 5,17 * * *"


At minute 30 past hour 5 and 17

rodireich · 2023-10-17T16:43:23Z

.github/workflows/connector-performance-cron.yml


 jobs:
  postgres-1m-run:
    uses: ./.github/workflows/connector-performance-command.yml
    with:
-      connector: connectors/source-postgres
+      connector: "connectors/source-postgres"
      dataset: 1m


Are all dataset going to run every time? is this needed?

actually that's something I want to discuss with you. When we are going to support and test against full_refresh and incremental, and with additional mongoDB support, we will have maximum 18 combinations between connectors/dataset/sync mode. I feel we do not need to enumerate all datasets - what is the original purpose of defining 3 different datasets for performance testing?

I don't think 1m is giving us something that's very different than 10 or 20m.
I'm ok with leaving other datasets for manual testing where you may want to check a more specialized cases.

sounds good. removed 10m/20m for both connectors.

rodireich · 2023-10-20T17:28:20Z

.github/workflows/connector-performance-command.yml

-          github.event.inputs.connector != 'connectors/destination-snowflake' }}"
+        if: "${{ inputs.connector != 'connectors/source-postgres' &&
+          inputs.connector != 'connectors/source-mysql' &&
+          inputs.connector != 'connectors/destination-snowflake' }}"


make sure that mongodb from the other PR doesn't get run over during merge

…hq#31480)

xiaohansong added 8 commits October 16, 2023 14:03

test 1

0886fce

fix

e88826e

add type string

84581e4

inherit secret

89494e5

test

4e450e3

replace github.event.inputs to inputs

1658aa6

add other 2 required inputs to run harness

fd4c8aa

add cron

ffe54f1

format

45c66e0

xiaohansong requested review from rodireich and git-phu October 16, 2023 22:41

xiaohansong marked this pull request as ready for review October 16, 2023 22:41

rodireich reviewed Oct 17, 2023

View reviewed changes

xiaohansong added 3 commits October 17, 2023 12:24

keep 1m dataset only

a050de3

add comment to explain cron

946f694

format

21eb87f

xiaohansong requested a review from rodireich October 17, 2023 22:12

rodireich reviewed Oct 20, 2023

View reviewed changes

rodireich approved these changes Oct 20, 2023

View reviewed changes

xiaohansong added 3 commits October 20, 2023 10:48

Merge remote-tracking branch 'origin/master' into xiaohan/cron-update

8540151

add incremental and mongodb in cron

409b397

add type string

5121d16

xiaohansong merged commit 4ce51c1 into master Oct 20, 2023
34 checks passed

xiaohansong deleted the xiaohan/cron-update branch October 20, 2023 18:38

ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023

Create a cron job that calls all performance harness on cron (airbyte…

83c1830

…hq#31480)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create a cron job that calls all performance harness on cron #31480

Create a cron job that calls all performance harness on cron #31480

xiaohansong commented Oct 16, 2023 •

edited

Loading

vercel bot commented Oct 16, 2023 •

edited

Loading

rodireich Oct 17, 2023

rodireich Oct 17, 2023

xiaohansong Oct 17, 2023 •

edited

Loading

rodireich Oct 17, 2023

xiaohansong Oct 17, 2023

rodireich Oct 20, 2023

Create a cron job that calls all performance harness on cron #31480

Create a cron job that calls all performance harness on cron #31480

Conversation

xiaohansong commented Oct 16, 2023 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Actions

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Airbyter

vercel bot commented Oct 16, 2023 • edited Loading

rodireich Oct 17, 2023

Choose a reason for hiding this comment

rodireich Oct 17, 2023

Choose a reason for hiding this comment

xiaohansong Oct 17, 2023 • edited Loading

Choose a reason for hiding this comment

rodireich Oct 17, 2023

Choose a reason for hiding this comment

xiaohansong Oct 17, 2023

Choose a reason for hiding this comment

rodireich Oct 20, 2023

Choose a reason for hiding this comment

xiaohansong commented Oct 16, 2023 •

edited

Loading

vercel bot commented Oct 16, 2023 •

edited

Loading

xiaohansong Oct 17, 2023 •

edited

Loading